Repository navigation
chore: ignore deprecated extension warnings in the check and format UIs - #1618
Draft
joaodinissf wants to merge 1 commit into
Draft
joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
Eclipse reports 27 warnings on org.eclipse.ui.editorActions and org.eclipse.ui.popupMenus in these three plugin.xml files. Most are the breakpoint actions Xtext's XbaseGeneratorFragment2 generates unconditionally, with no option to leave them out. The double-click breakpoint can't move to commands without a custom editor, as AbstractTextEditor reads it only from editorActions. Deploy and Undeploy in check.ui use the same deprecated mechanism. Set compilers.p.deprecated to ignore in these three projects only, as two of Xtext's example UI projects do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joaodinissf
marked this pull request as ready for review
November 6, 2026 00:54
Collaborator
Author
|
We're reworking this, so it doesn't need a review as it is. Moving it back to draft. Posted by Claude Code on behalf of @joaodinissf. |
joaodinissf
marked this pull request as draft
November 6, 2026 07:45
Member
|
I wonder if this is true. If it is so that Xtext writes block unconditionally that point to deprecated stuff, probably a PR for Xtext is better |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignores the 27 deprecation warnings Eclipse reports on
org.eclipse.ui.editorActionsandorg.eclipse.ui.popupMenusincheck.ui,checkcfg.uiandxtext.format.ui.The problem
24 of the warnings are the breakpoint actions from Xtext's
XbaseGeneratorFragment2, which writes this block unconditionally, 8 per bundle. The other 3 are the hand-written Deploy and Undeploy menus incheck.ui.These entries are in use.
Not Usedis the label of the double-click breakpoint toggle, andAbstractTextEditorreadsRulerDoubleClickonly fromeditorActions, so moving to commands would need a custom editor and ruler handlers. Xtext has no option to leave the block out, and its ownxtend.ideand example projects keep these entries.The change
Adds
.settings/org.eclipse.pde.prefswithcompilers.p.deprecated=2(ignore) to these three projects only, as two of Xtext's example UI projects do. This also hides any other PDE deprecation warning in these three projects. It affects Eclipse only: nothing changes at runtime, and it doesn't reach language authors downstream.Also bumps the three bundles, as the version baseline check requires.
Testing
clean verifywithcheckstyle:check,pmd:check,pmd:cpd-checkandspotbugs:checkpasses, including the version baseline check. 451 tests ran with no failures or errors, and 2 were skipped.🤖 Generated with Claude Code